Skip to content
This repository was archived by the owner on Apr 30, 2020. It is now read-only.

Conversation

@hroncok
Copy link
Member

@hroncok hroncok commented Oct 1, 2018

cc @frantisekz

Let's see what breaks.

@hroncok hroncok added the WIP label Oct 1, 2018
@hroncok
Copy link
Member Author

hroncok commented Oct 1, 2018

So apparently (as expected) everything fails totally.

@hroncok
Copy link
Member Author

hroncok commented Oct 1, 2018

The downloader doesn't have the libtaskotron module.

ModuleNotFoundError: No module named 'libtaskotron'

@hroncok
Copy link
Member Author

hroncok commented Oct 1, 2018

There are RPMs missing to be able to run this:

$ dnf repoquery --repo=rawhide -f /usr/lib/python2.7/site-packages/libtaskotron/__init__.py
libtaskotron-core-0:0.9.0-1.fc30.noarch
$ dnf repoquery --repo=rawhide -f /usr/lib/python3.7/site-packages/libtaskotron/__init__.py
(nothing)

@frantisekz
Copy link

Yes, I am planning to build Py3 Taskotron in Rawhide soon™ . For now, the packages are available here: https://copr.fedorainfracloud.org/coprs/kparal/taskotron-dev/builds/

@hroncok hroncok force-pushed the python3 branch 4 times, most recently from 6b9616e to db8feaf Compare October 1, 2018 14:15
@hroncok hroncok force-pushed the python3 branch 2 times, most recently from 2f72f91 to 63a632e Compare October 1, 2018 15:17
@hroncok
Copy link
Member Author

hroncok commented Oct 1, 2018

So there was a bug with bytes encoded requires leaking b'' into the log.
I've decided to get it solved properly by not dealing with bytes encoded requires at all.
Should work now. I guess.

@frantisekz
Copy link

Ok, it seems it's working fine on our dev instance: https://taskotron-dev.fedoraproject.org

@hroncok
Copy link
Member Author

hroncok commented Oct 1, 2018

rawhide test failing. But the fial is in mock init, so something is weird, will rerun it.

@hroncok
Copy link
Member Author

hroncok commented Oct 1, 2018

This seems to work.

Can this go into develop?

@frantisekz
Copy link

This seems to work.

Can this go into develop?

Yes, but please, keep the "python3" branch in sync with it, if you want to add and run the new commits on taskotron-dev.

@hroncok
Copy link
Member Author

hroncok commented Nov 8, 2018

Offtopic: Any idea when libtaskotron package will be Python 3 in Fedora rawhide?

@frantisekz
Copy link

Right about now :)
https://koji.fedoraproject.org/koji/buildinfo?buildID=1161786

If everything goes without any issues, it should be deployed to production sometimes next week.

If W504 or W503 is not ignored, it always bugs you.
Normally, one of them is ignored by default, but we redefine what's ignored.

W503: line break before binary operator
W504: line break after binary operator
@hroncok
Copy link
Member Author

hroncok commented Nov 15, 2018

Current state: Dropped the copr repo, the tests will fail, as the update is still pending to stable, but rawhide might work. Tomorrow, I'll rerun the tests.

I will merge this to devel as soon as the tests succeed. (Let me know when I can remove the python3 branch).

After a day or two, I merge to master as well (let me know if I should not).

Update the list of taskotron packages we need
@frantisekz
Copy link

Python 3 Taskotron is in stable repos now and it's been deployed to the production instance.

@hroncok hroncok changed the title WIP: Use python3 everywhere Use python3 everywhere Nov 16, 2018
@hroncok hroncok merged commit 930abc3 into develop Nov 16, 2018
@hroncok hroncok deleted the python3 branch November 16, 2018 12:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants